Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fbthrift: update to 2022.08.08.00, fix build with gcc and on older OS #15736

Merged
merged 1 commit into from Aug 31, 2022
Merged

fbthrift: update to 2022.08.08.00, fix build with gcc and on older OS #15736

merged 1 commit into from Aug 31, 2022

Conversation

barracuda156
Copy link
Contributor

Description

Update to the current version, fix build with gcc and on older systems.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 Server
Xcode 3.2.6

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@barracuda156
Copy link
Contributor Author

Buildbots fail on these:

ThriftServerConfig.h:860:3: error: unknown type name 'FOLLY_CONSTEVAL'

ThriftServerConfig.h:860:49: error: expected ';' at end of declaration list
    THRIFT_SERVER_INITIAL_CONFIG_DEFINE(uint32_t, maxRequests)

ThriftServerConfig.h:868:19: error: constructor cannot have a return type
    FOLLY_CONSTEVAL ThriftServerInitialConfig(

I suspect it may be due to the fact that master branch has earlier versions of dependencies. (I kept these ports in separate PRs to avoid the mess with rebasing.)
Once folly, fizz and wangle are merged (they pass all checks), this should build fine too.

@barracuda156
Copy link
Contributor Author

UPD. Rebased, will try fixing it.

@mascguy
Copy link
Member

mascguy commented Aug 31, 2022

UPD. Rebased, will try fixing it.

Yep, looks good now.

@mascguy mascguy merged commit 7899b38 into macports:master Aug 31, 2022
@barracuda156 barracuda156 deleted the fbthrift branch August 31, 2022 17:22
mascguy added a commit that referenced this pull request Aug 31, 2022
@mascguy
fbthrift: disable aligned_alloc for 10.13 and earlier
aa18354 
See: #15736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mascguy mascguy mascguy approved these changes

Assignees
No one assigned
Labels
maintainer: none type: bugfix type: enhancement type: update
Milestone
No milestone
3 participants
@barracuda156 @mascguy @macportsbot